20 Oct
2025
20 Oct
'25
2:29 p.m.
Nikolay Sivov (@nsivov) commented about dlls/comctl32/datetime.c:
static void DATETIME_Refresh (DATETIME_INFO *infoPtr, HDC hdc) { +#if __WINE_COMCTL32_VERSION == 6 HTHEME theme; int state; +#endif
TRACE("\n"); This part, and splitting 'if' branches is what I don't like the most about this. Especially when there multiple places in the same function. Could we maybe have more helpers instead, where conditions are localized within a single function as close as possible.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9221#note_119054