Re: [PATCH v2 0/7] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.c:
> return true;
>  }
>
> +bool hlsl_init_deref_from_index_chain(struct hlsl_ctx *ctx, struct hlsl_deref *deref, struct hlsl_ir_node *chain)
> +{
> +    struct hlsl_ir_index *index;
> +    struct hlsl_ir_load *load;
> +    unsigned int chain_len, i;
> +    struct hlsl_ir_node *ptr;
> +
> +    deref->path = NULL;
> +    deref->path_len = 0;
> +    deref->offset.node = NULL;
> +
> +    if (!chain)
> +        return true;

I'd be mildly inclined to punt this to the caller, it seems less confusing to someone reading this function without context.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124#note_27460