Re: [PATCH v4 0/6] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.

[eric pouech (＠epo)]

eric pouech (@epo) commented about dlls/kernel32/toolhelp.c:
> LDR_DATA_TABLE_ENTRY *mod = NULL;
>      ULONG               num_pcs, num_thd, num_mod;
>      HANDLE              hSnapShot = 0;
> +    DWORD               supported_flags = TH32CS_SNAPPROCESS|TH32CS_SNAPTHREAD|TH32CS_SNAPMODULE;
>
> TRACE("%lx,%lx\n", flags, process );
> -    if (!(flags & (TH32CS_SNAPPROCESS|TH32CS_SNAPTHREAD|TH32CS_SNAPMODULE)))

I'm not sure we want that... if an app requests say module+heaps, before we were returning success + modules (and zero heaps), with this change the call will fail

perhaps we'd better just add a WARNa about unsupported flags

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9371#note_121003