21 Mar
2024
21 Mar
'24
4:59 a.m.
Jinoh Kang (@iamahuman) commented about dlls/win32u/winstation.c:
+ NTSTATUS status; + + switch (type) + { + case OBJECT_TYPE_DESKTOP: + SERVER_START_REQ( get_thread_desktop ) + { + req->tid = tid; + if (!(status = wine_server_call( req ))) + { + info->id = reply->object_id; + info->index = reply->index; + } + } + SERVER_END_REQ; + break; Uninitialized `status` on unrecognized object type.
```suggestion:-0+0 break; default: ERR( "unknown object type %d\n", type ); status = STATUS_UNSUCCESSFUL; break; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_65572