31 Jul
2024
31 Jul
'24
1:34 p.m.
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/propsheet.c:
psInfo->ppshheader.pszCaption); }
+ for (int index = 0; index < psInfo->nPages;) + { + if (HPSP_get_flags(psInfo->proppage[index].hpage) & PSP_PREMATURE)
It's cleaner if you write it like ``` DWORD premature = HPSP_get_flags(psInfo->proppage[index].hpage) & PSP_PREMATURE; if (premature && !PROPSHEET_CreatePage(hwnd, index, psInfo, psInfo->proppage[index].hpage)) PROPSHEET_RemovePage(hwnd, index, NULL); else index++; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6146#note_77415