17 Nov
2025
17 Nov
'25
1:37 p.m.
On Mon Nov 17 13:37:36 2025 +0000, Brendan Shanks wrote:
Overall looks good, I tested the 3 code paths. Hi Brendan,
Thanks for the review! I pushed a v2 with changes according to your comment. v2: - Adjustments for the recent deletion of macdrv_get_displays(). - Call IOObjectRelease(service)/CFRelease(avservice) right after IOAVServiceCreateWithService()/IOAVServiceCopyEDID(). - Check CFDataGetLength(edid) before access edid_ptr[n]. - Initialize i when modes is NULL in generate_edid(). - Simply EDID buffer allocation in generate_edid(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8925#note_122539