21 Sep
2022
21 Sep
'22
1:54 p.m.
Huw Davies (@huw) commented about server/registry.c:
if ((key = create_key( parent, &name, 0, KEY_WOW64_64KEY, 0, sd ))) { - load_registry( key, req->file ); + filename = calloc( 1, req_data_len + 1 ); + memcpy( filename, req_data, req_data_len ); +
Calling `malloc()` and explicitly adding the '\0' would be more efficient. Testing that `malloc()` succeeds would be good too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8973