23 Nov
2023
23 Nov
'23
9:22 a.m.
Rémi Bernon (@rbernon) commented about dlls/winegstreamer/media_sink.c:
+ } + + hr = MFPutWorkItem(MFASYNC_CALLBACK_QUEUE_STANDARD, &media_sink->async_callback, &command->IUnknown_iface); + + LeaveCriticalSection(&media_sink->cs); + + return hr; }
static HRESULT WINAPI media_sink_EndFinalize(IMFFinalizableMediaSink *iface, IMFAsyncResult *result) { - FIXME("iface %p, result %p stub!\n", iface, result); + TRACE("iface %p, result %p.\n", iface, result);
- return E_NOTIMPL; + return result ? IMFAsyncResult_GetStatus(result) : E_INVALIDARG; Here as well, can `result` be NULL?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4479#note_53487