Re: [PATCH v5 0/2] MR740: Implement hyperbolic trigonometry operations.

[Petrichor Park (＠petrathekat)]

On Fri Apr 12 00:24:26 2024 +0000, Henri Verbeet wrote:
> > ```diff
> > +    static const char fn_name_sinh[] = "sinh";
> > +    static const char fn_name_cosh[] = "cosh";
> > +
> > +    if (!(arg = intrinsic_float_convert_arg(ctx, params,
>
> params->args[0], loc)))
> > +        return false;
> > +    type = arg->data_type;
> > +
> > +    fn_name = sinh_mode ? fn_name_sinh : fn_name_cosh;
> > +    combiner = sinh_mode ? "-" : "+";
> > +
> > +    if (!(body = hlsl_sprintf_alloc(ctx, template,
> > +            type->name, fn_name, type->name,
> > +            combiner)))
> > +        return false;
> > ```
> > So
>     type_name = arg->data_type->name;
>     if (!(body = hlsl_sprintf_alloc(ctx, template, type_name,
>             sinh_mode ? "sinh" : "cosh", type_name,
>             sinh_mode ? "-" : "+")))
>         return false;
>
> right?
> Yes. I thought it would be better to write it out longhand (I've been told to be more verbose in the past) but I can fix that.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/740#note_67664