Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/surface.c:
get_relevant_argb_components(ck_conv_info, src_ptr, channels); ck_pixel = make_argb_color(ck_conv_info, channels); - if (ck_pixel == color_key) + for (i = 0; i < 4; ++i) + { + const uint8_t ck_channel = (ck_pixel >> (24 - (i * 8))) & 0xff; + + if ((ck_channel >= color_key->color_key_min[i]) != (ck_channel <= color_key->color_key_max[i])) + break;
I'd have written this more naturally (to me) as: ```suggestion:-1+0 if ((ck_channel < color_key->color_key_min[i]) || (ck_channel > color_key->color_key_max[i])) break; ``` But maybe I'm missing something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7711#note_102882