8 Mar
2024
8 Mar
'24
7:56 a.m.
Huw Davies (@huw) commented about dlls/comdlg32/printdlg.c:
} break;
- case cmb1: /* Printer Combobox in PRINT SETUP */ - /* FALLTHROUGH */ + case cmb1: /* Printer Combobox in PRINT SETUP, quality combobox in PRINT16 */ + if (PrinterComboID != LOWORD(wParam)) { + break; + }
```suggestion:-0+0 } /* FALLTHROUGH */ ``` The commit message could be better, e.g. ``` comdlg32: Don't treat cmb1 as the printer list unless in PRINT_SETUP. This changes WMCommandW to match WMCommandA. ``` Essentially swapping the subject with the sentence in the body. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4971#note_63960