12 Oct
2023
12 Oct
'23
1:59 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d/vkd3d_private.h:
{ }
+typedef PFLS_CALLBACK_FUNCTION vkd3d_tls_destructor_fn; + +static inline int vkd3d_tls_key_create(struct vkd3d_tls_key *key, vkd3d_tls_destructor_fn destructor) I'd move the logging inside `vkd3d_tls_key_create()`, so that each implementation can meaningfully log its own error value (either the returned value or `GetLastError()`), at which point `vkd3d_tls_key_create()` can just return a `bool`.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384#note_48507