[PATCH v3 4/4] msxml3/tests: Add a test for handler property types in VB API.

[Nikolay Sivov]

From: Nikolay Sivov <[e-mail]>

Signed-off-by: Nikolay Sivov <[e-mail]>
---
 dlls/msxml3/tests/saxreader.c | 47 ++++++++++++++++++++++++++---------
 1 file changed, 35 insertions(+), 12 deletions(-)

diff --git a/dlls/msxml3/tests/saxreader.c b/dlls/msxml3/tests/saxreader.c
index 454846292a3..24286c915f9 100644
--- a/dlls/msxml3/tests/saxreader.c
+++ b/dlls/msxml3/tests/saxreader.c
@@ -2741,21 +2741,22 @@ static void test_saxreader(void)
     free_bstrs();
 }
 
-struct saxreader_props_test_t
-{
-    const WCHAR *prop_name;
-    IUnknown   *iface;
-};
-
-static const struct saxreader_props_test_t props_test_data[] = {
-    { L"http://xml.org/sax/properties/lexical-handler", (IUnknown*)&lexicalhandler.ISAXLexicalHandler_iface },
-    { L"http://xml.org/sax/properties/declaration-handler", (IUnknown*)&declhandler.ISAXDeclHandler_iface },
-    { 0 }
-};
-
 static void test_saxreader_properties(void)
 {
+    static const struct saxreader_props_test_t
+    {
+        const WCHAR *prop_name;
+        IUnknown *iface;
+    }
+    props_test_data[] =
+    {
+        { L"http://xml.org/sax/properties/lexical-handler", (IUnknown *)&lexicalhandler.ISAXLexicalHandler_iface },
+        { L"http://xml.org/sax/properties/declaration-handler", (IUnknown *)&declhandler.ISAXDeclHandler_iface },
+        { 0 }
+    };
+
     const struct saxreader_props_test_t *ptr = props_test_data;
+    IVBSAXXMLReader *vb_reader;
     ISAXXMLReader *reader;
     HRESULT hr;
     VARIANT v;
@@ -2905,6 +2906,28 @@ static void test_saxreader_properties(void)
 
     ISAXXMLReader_Release(reader);
 
+    /* Getters with VB interface */
+    hr = CoCreateInstance(&CLSID_SAXXMLReader, NULL, CLSCTX_INPROC_SERVER, &IID_IVBSAXXMLReader, (void **)&vb_reader);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    V_VT(&v) = VT_EMPTY;
+    V_DISPATCH(&v) = (IDispatch *)0xdeadbeef;
+    hr = IVBSAXXMLReader_getProperty(vb_reader, _bstr_("http://xml.org/sax/properties/lexical-handler"), &v);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    todo_wine
+    ok(V_VT(&v) == VT_DISPATCH, "Unexpected type %d.\n", V_VT(&v));
+    ok(!V_DISPATCH(&v), "Unexpected value %p.\n", V_UNKNOWN(&v));
+
+    V_VT(&v) = VT_EMPTY;
+    V_UNKNOWN(&v) = (IUnknown*)0xdeadbeef;
+    hr = IVBSAXXMLReader_getProperty(vb_reader, _bstr_("http://xml.org/sax/properties/declaration-handler"), &v);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    todo_wine
+    ok(V_VT(&v) == VT_DISPATCH, "Unexpected type %d.\n", V_VT(&v));
+    ok(!V_DISPATCH(&v), "Unexpected value %p.\n", V_UNKNOWN(&v));
+
+    IVBSAXXMLReader_Release(vb_reader);
+
     if (!is_clsid_supported(&CLSID_SAXXMLReader40, reader_support_data))
         return;
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10143