Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/afd.c:
return io->ret; }
-static NTSTATUS WINAPI thread_NtDeviceIoControlFile(BOOL kill_thread, BOOL other_process_handle, HANDLE *handle, HANDLE event, - PIO_APC_ROUTINE apc, void *apc_context, IO_STATUS_BLOCK *io, ULONG code, void *in_buffer, ULONG in_size, - void *out_buffer, ULONG out_size) +enum test_close_handle_type +{ + TEST_CLOSE_SAME_PROCESS, + TEST_CLOSE_OTHER_BEFORE_THREAD_EXIT, + TEST_CLOSE_OTHER_AFTER_THREAD_EXIT, +}; + +static NTSTATUS WINAPI thread_NtDeviceIoControlFile(BOOL kill_thread, enum test_close_handle_type other_process_handle,
As long as we're changing "other_process_handle" to "close_type" elsewhere we should do it here. I also suspect that things would be a bit more clear if we didn't do "if (close_type)" kind of comparisons. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3329#note_39001