Re: [PATCH v5 0/10] MR159: vkd3d-shader/hlsl: Broaden resources support v2, part 2.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
> return false;
>
> +        dim = var->objects_usage[regset][index].sampler_dim;
> +        if (dim != load->sampling_dim)
> +        {
> +            if (dim == HLSL_SAMPLER_DIM_GENERIC)
> +            {
> +                var->objects_usage[regset][index].first_sampler_dim_loc = instr->loc;
> +            }
> +            else
> +            {
> +                hlsl_error(ctx, &instr->loc, VKD3D_SHADER_ERROR_HLSL_INCONSISTENT_SAMPLER,
> +                        "Inconsistent generic sampler usage dimension.");
> +                hlsl_note(ctx, &var->objects_usage[regset][index].first_sampler_dim_loc,
> +                        VKD3D_SHADER_LOG_ERROR, "First use is here.");
> +                return false;

Can we have a test for this?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159#note_31216