8 Jun
2023
8 Jun
'23
6:16 a.m.
Huw Davies (@huw) commented about dlls/mmdevapi/client.c:
+ struct audio_client *This = impl_from_IAudioClient3(iface); + struct get_device_period_params params; + + TRACE("(%p)->(%p, %p)\n", This, defperiod, minperiod); + + if (!defperiod && !minperiod) + return E_POINTER; + + params.device = This->device_name; + params.flow = This->dataflow; + params.def_period = defperiod; + params.min_period = minperiod; + + WINE_UNIX_CALL(get_device_period, ¶ms); + + return S_OK; Why are we returning `S_OK` unconditionally here? All of the drivers return `params.result`.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3009#note_35077