28 May
2024
28 May
'24
8:52 p.m.
On Wed Apr 24 19:07:57 2024 +0000, Elizabeth Figura wrote:
The tests are missing any todo_wine annotations, which is suspect. We need the tests to pass after every commit, which entails adding and removing todo_wine accordingly. Oh, I see, now I know.
But I guess it's still a good idea to introduce tests in a separate commit? At least the removal of `wine_todo`s gives good indication what the commit is aiming for.. Now the first commit brings in tests with some parts annotated with `todo_wine` and the second commit removes annotations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5519#note_68771