Re: [PATCH v2 0/1] MR180: vkd3d-shader/hlsl: Partially implement static expressions evaluation.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.y:
> -    if (t1 > HLSL_TYPE_LAST_SCALAR || t2 > HLSL_TYPE_LAST_SCALAR) {
> -        FIXME("Unexpected base type.\n");
> -        return HLSL_TYPE_FLOAT;
> -    }
> -    if (t1 == t2)
> -        return t1 == HLSL_TYPE_BOOL ? HLSL_TYPE_INT : t1;
> -    if (t1 == HLSL_TYPE_DOUBLE || t2 == HLSL_TYPE_DOUBLE)
> -        return HLSL_TYPE_DOUBLE;
> -    if (t1 == HLSL_TYPE_FLOAT || t2 == HLSL_TYPE_FLOAT
> -            || t1 == HLSL_TYPE_HALF || t2 == HLSL_TYPE_HALF)
> -        return HLSL_TYPE_FLOAT;
> -    if (t1 == HLSL_TYPE_UINT || t2 == HLSL_TYPE_UINT)
> -        return HLSL_TYPE_UINT;
> -    return HLSL_TYPE_INT;
> -}
> -
> I don't think you need to move this anymore, right?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/180#note_31334