24 Jan
2024
24 Jan
'24
12:34 p.m.
Martin Storsjö (@mstorsjo) commented about dlls/ntdll/unix/system.c:
if (i > 8 * sizeof(ULONG_PTR)) { - FIXME("skipping logical processor %d\n", i); - continue; + FIXME("skipping logical processor %d up to %d\n", i, end);
Alternatively, perhaps this `FIXME()` message could be skipped altogether (or demoted to a `TRACE()`?), as there's another message right above, on line 914, `FIXME("Improve CPU info reporting: system supports %u logical cores, but only %u supported!\n", max_cpus, MAXIMUM_PROCESSORS);`, which also triggers in the same cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4929#note_58816