Re: [PATCH 0/6] MR717: vkd3d-shader/fx: Add initial support for writing fx_2_0 parameters.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/fx.c:
> +    uint32_t class;
> +    static const uint32_t param_class[] =
> +    {
> +        [HLSL_CLASS_SCALAR] = D3DXPC_SCALAR,
> +        [HLSL_CLASS_VECTOR] = D3DXPC_VECTOR,
> +        [HLSL_CLASS_MATRIX] = D3DXPC_MATRIX_COLUMNS,
> +        [HLSL_CLASS_OBJECT] = D3DXPC_OBJECT,
> +        [HLSL_CLASS_STRUCT] = D3DXPC_STRUCT,
> +    };
> +    static const uint32_t param_type[] =
> +    {
> +        [HLSL_TYPE_BOOL]  = D3DXPT_BOOL,
> +        [HLSL_TYPE_INT]   = D3DXPT_INT,
> +        [HLSL_TYPE_FLOAT] = D3DXPT_FLOAT,
> +        [HLSL_TYPE_VOID]  = D3DXPT_VOID,
> +    };
> This could reuse the existing helpers in d3dbc.c...

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/717#note_64636