Re: [PATCH 0/3] MR1067: jscript: Bind function 'thisArg' and JSON.parse improvements.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/jscript/json.c:
> +{
> +    jsval_t res, args[2];
> +    const WCHAR *str;
> +    HRESULT hres;
> +
> +    if(!(str = jsstr_flatten(name)))
> +        hres = E_OUTOFMEMORY;
> +    else
> +        hres = jsdisp_propget_name(holder, str, &args[1]);
> +    if(FAILED(hres)) {
> +        proc_ctx->hres = hres;
> +        return jsval_undefined();
> +    }
> +
> +    if(is_object_instance(args[1])) {
> +        jsdisp_t *obj = as_jsdisp(get_object(args[1]));
> It seems that we shouldn't assume that the object is of jsdisp_t type, reviewer may have already replaced it with any object type (it's probably fine to have a FIXME for that, through).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1067#note_10765