16 Nov
2024
16 Nov
'24
6:39 a.m.
Jinoh Kang (@iamahuman) commented about dlls/dsound/tests/ds3d.c:
buffer_param.vPosition.x,buffer_param.vPosition.y, buffer_param.vPosition.z,DS3D_IMMEDIATE); ok(rc==DS_OK,"IDirectSound3dBuffer_SetPosition() failed: %08lx\n", rc); + rc=IDirectSound3DBuffer_SetPosition(buffer, + NAN,NAN,NAN,DS3D_IMMEDIATE);
It would be nice if we tested each parameter separately: - NAN, 0, 0 - 0, NAN, 0 - 0, 0, NAN This matches the trend of other tests, and ensures that all of x, y, and z are checked for NAN. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6289#note_87716