Re: [PATCH v2 0/7] MR1697: localspl: Use print processor + SeekPrinter

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/localspl/provider.c:
> +    if (!print_proc_check_datatype(pp, datatype))
>      {
> -        info.pDocName = job->document_title;
> -        info.pOutputFile = (WCHAR *)port;
> -        info.pDatatype = NULL;
> -        ret = ret_startdoc = mon->monitor.pfnStartDocPort(hport, printer->info->name,
> -                job_id, 1, (BYTE *)&info);
> +        WARN("%s datatype not supported by %s\n", debugstr_w(datatype),
> +                debugstr_w(printer->info->print_proc));
> +        print_proc_unload(pp);
> +        return FALSE;
>      }
>
> -    while (ret && ReadFile(hf, buf, sizeof(buf), &r, NULL) && r)
> -        ret = mon->monitor.pfnWritePort(hport, buf, r, &w) && r == w;
> +    swprintf(name, ARRAY_SIZE(name), L"%s, Port", port_name);
> Sorry, missed this earlier, but shouldn't this be:
    swprintf(name, ARRAY_SIZE(name), L"%s, Port %s", printer->name, port_name);

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1697#note_18812