Re: [PATCH 0/1] MR1564: hhctrl: Use standard C functions for memory allocation.

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about dlls/hhctrl.ocx/chm.c:
> -                    chm->strings_size*sizeof(char*));
> -            if(!new_strings)
> -                return NULL;
> -            chm->strings = new_strings;
> -        }else {
> -            chm->strings = heap_alloc_zero(
> -                    chm->strings_size*sizeof(char*));
> -            if(!chm->strings)
> -                return NULL;
> -        }
> -
> +        new_strings_size = (offset >> BLOCK_BITS) + 1;
> +        new_strings = realloc(chm->strings, new_strings_size * sizeof(char*));
> +        if(!new_strings)
> +            return NULL;
> +        memset(new_strings + (offset >> BLOCK_BITS), 0, sizeof(char*));
> This doesn't look right.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1564#note_17896