25 Jul
2023
25 Jul
'23
7:04 p.m.
On Tue Jul 25 12:45:01 2023 +0000, Gabriel Ivăncescu wrote:
Sorry I missed this last time, but I think you should add some exposed props here (and test them), them being stubs of course. i.e. test `disconnect`, `observe`, `takeRecords` for example and see what it exposes. Not that it matters much but having an empty interface just strikes odd. `observe` would take a IHTMLDOMNode and an IDispatch for example (if it's even exposed on native). `takeRecords` would return an IDispatch (jscript arrays are objects). This is just for the signature since you aren't implementing them. how do i create a js array from mshtml? do i call `create_array`?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3391#note_40228