Re: [PATCH 0/4] MR9348: comctl32/imagelist: Pre-multiply rgb by the alpha channel in add_dib_bits for v6.

[Zhiyi Zhang (＠zhiyi)]

On Mon Nov 17 04:10:29 2025 +0000, Ziqing Hui wrote:
> > > Let's not make changes to both v5 and v6 at the same time. It would
> > > be easier for review if you could split them.
> >
> > In fact, although I use `#if __WINE_COMCTL32_VERSION == 5` here, it
> > only changes v6. For v6 I added code that premultiply alpha channel in
> > `add_dib_bits`, so we need to remove this line for v6. To keep it the
> > same as before for v5, I added a v5 guard.
> > Maybe it would be better if I find some way to replace `#if
> > __WINE_COMCTL32_VERSION == 5` with `#if __WINE_COMCTL32_VERSION == 6`?
> > If it's cleaner, yes. The main point is to avoid making changes to both v5 and v6 in the same patch.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9348#note_122696