Re: [PATCH 0/8] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
> put_u32(buffer, token);
>
> for (j = 0; j < instr->dsts[i].reg.idx_count; ++j)
> -            put_u32(buffer, instr->dsts[i].reg.idx[j]);
> +            put_u32(buffer, instr->dsts[i].reg.idx[j].offset);

Here you're ignoring `rel_addr`, which I guess is correct because at this stage it's never expected to be set, is that right? If so, please add an `assert()`, even if it's temporary.

Same thing just below.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281#note_39586