Re: [PATCH v5 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/propsheet.c:
> +    LPNMHDR lpnmhdr;
> +
> +    switch (uMessage)
> +    {
> +    case WM_NOTIFY:
> +        lpnmhdr = (NMHDR *)lParam;
> +        switch (lpnmhdr->code)
> +        {
> +        case PSN_QUERYINITIALFOCUS:
> +        {
> +            if (!query_initial_focus)
> +            {
> +                SetWindowLongPtrA(hdlg, DWLP_MSGRESULT, (LONG_PTR)GetDlgItem(hdlg, IDC_PS_EDIT2));
> +                query_initial_focus = 1;
> +                return 1;
> +            }else
> A coding style nitpick. Please move "else" on a newline and add curly braces around "query_initial_focus = 0;", even if it's just one line here because there are curly braces in the previous branch.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6145#note_77419