22 Oct
2025
22 Oct
'25
4:29 p.m.
Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/main.c:
+ WARN("Unexpected source length %lu.\n", current_length); + hr = MF_E_UNEXPECTED; + goto done_unlock_dst; + } + + src_stride = frame_width * format_size; + src += src_rect.top * src_stride + src_rect.left * format_size; + MFCopyImage(dst, dst_stride, src, src_stride, dst_stride, wic_rect.Height); + + IMFMediaBuffer_Unlock(media_buffer); + +done_unlock_dst: + IWICBitmapLock_Release(lock); +done: + IMFMediaBuffer_Release(media_buffer); + return hr; Could we replace this with a single goto, checking for null 'lock' instead?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9125#note_119336