8 Jun
2024
8 Jun
'24
12:21 p.m.
On Sat Jun 8 12:16:43 2024 +0000, Jinoh Kang wrote:
There's the only single test commit, and it's already a separate one.
Being separate isn't enough, it should be moved earlier in the order of commits.
Remaning patches don't introduce new tests.
Yes, which is why I believe this might need more tests. Previous comment was wrong about the tests. Sorry for confusion. Personally I think that existing tests cover most of the being fixed functionality judging by the amount of removed todo_wine statements.
Feel free to suggest the areas of new tests to add though, I'm open to suggestions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5665#note_72787