Re: [PATCH v4 0/8] MR4817: shell32: Implement some functions of IFileOperation.

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/shell32/shlfileop.c:
> +
> +end:
> +    free(from);
> +    free(to);
> +
> +    return ret;
> +}
> +
> +static void free_operation(struct file_operation *opt)
> +{
> +    if (opt)
> +    {
> +        if (opt->pNewName) free(opt->pNewName);
> +        if (opt->pTo) free(opt->pTo);
> +        if (opt->pTemplateName) free(opt->pTemplateName);
> +        if (opt->pFrom) free(opt->pFrom);
> Don't check for NULL just to call `free`, the `free` function already does that.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4817#note_58669