On Sun Jul 27 01:18:19 2025 +0000, Maotong Zhang wrote:
changed this line in [version 4 of the diff](/wine/wine/-/merge_requests/8608/diffs?diff_id=195508&start_sha=37cac38bf9904b66ed6c601183d87bf2f987f756#941712bdad220aba7d6798d478d2fe9a0ed5c6d0_2567_2567) Ah, we may have had some language difficulties. I only meant that the `(void*)` was unnecessary. I also found, since making that comment, that a different set of allocation/free functions are used with this variable.
I think the value should be allocated like this: `WCHAR* pszName = LocalAlloc(LMEM_FIXED, total_len * sizeof(WCHAR));` And the older value should be freed like this: `LocalFree(This->filterspecs[i].pszName);` I found this by looking for the definition of `StrDupW`, which is in `dlls/kernelbase/string.c`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8608#note_111157