Re: [PATCH v2 0/2] MR5020: Draft: kernelbase/file: implement CopyFile2

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/kernelbase/file.c:
> HeapFree( GetProcessHeap(), 0, buffer );
>      CloseHandle( h1 );
>      CloseHandle( h2 );
> -    if (ret) SetLastError( 0 );
>      return ret;
>  }
>
> +/***********************************************************************
> + *	CopyFileExW   (kernelbase.@)
> + */
> +BOOL WINAPI CopyFileExW( const WCHAR *source, const WCHAR *dest, LPPROGRESS_ROUTINE progress,
> +                         void *param, BOOL *cancel_ptr, DWORD flags )
> +{
> +    HRESULT ret;
> +    COPYFILE2_EXTENDED_PARAMETERS params;

This struct is partially uninitialized. But CopyFile2 currently doesn't read the unwritten fields, so I don't know if that's considered a problem.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5020#note_59994