Re: [PATCH v2 0/7] MR6703: msvcrt: Improve DBCS support for _strnicmp_l().

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/tests/string.c:
> +        win_skip("Skip _tolower_l tests.\n");
> +        return;
> +    }
> +
> +    ret = _tolower_l('\xa5', 0);
> +    ok(ret == 165, "Got %d.\n", ret);
> +    ret = _tolower_l('\xb9', 0);
> +    ok(ret == 185, "Got %d.\n", ret);
> +    ret = _tolower_l('a', 0);
> +    ok(ret == 97, "Got %d.\n", ret);
> +
> +    if (!setlocale(LC_ALL, ".936"))
> +    {
> +        win_skip("Skip _tolower_l tests.\n");
> +        return;
> +    }
> You're assuming that similar setlocale call will not fail in earlier tests. Shouldn't it be changed to `ok(setlocale(LC_ALL, ".936") != NULL, ...)`?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6703#note_85542