Re: [PATCH 0/2] MR475: vkd3d-shader/hlsl: Add radians() and degrees() functions.

[Francisco Casas (＠fcasas)]

On Wed Nov 15 23:15:01 2023 +0000, Francisco Casas wrote:
> Oh, good catch! log/log10 also need this call to
> `hlsl_block_add_instr()`. I think it is just serendipity that
> compilation works without these nodes getting inserted in the
> instruction block.
> You can improve this MR with a commit adding those missing calls for the
> log/log10 functions. I don't think that an `add_float_constant()` helper
> is necessary though.
> Oh sorry @nsivov, I thought that I was replying to @sgwaki. The similarity in the user avatars got me confused.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/475#note_52449