24 Jun
2024
24 Jun
'24
9:28 a.m.
Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_parser.c:
pthread_mutex_lock(&parser->mutex);
- assert(stream->buffer); - + if (stream->buffer) + { gst_buffer_unmap(stream->buffer, &stream->map_info); gst_buffer_unref(stream->buffer); stream->buffer = NULL; + }
Maybe instead avoid calling `wg_parser_stream_release_buffer` if `wg_parser_stream_copy_buffer` failed in `media_stream_send_sample`? Maybe even merging the change into c4c2d23e9c190d94dc9393a56a6293af679f49fb. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5917#note_74200