Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/effect.c:
> +     97, 110, 107,   0,   0,   0
> +};
> +
> +struct test_set_raw_data_value
> +{
> +    D3DXPARAMETER_TYPE param_type;
> +    unsigned int expected_data_len;
> +    unsigned int param_data_len;
> +    unsigned int offset;
> +    HRESULT expected_result;
> +    const void *expected_data;
> +    const char *param_name;
> +    const void *param_data;
> +};
> +
> +static const int SET_RAWDATA_BOOL44_A[16] = { 1 };
> All caps names are usually reserved to preprocessor directives and enum values. Please use lowercase names for these.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11086