24 Nov
2023
24 Nov
'23
11:02 a.m.
Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c:
set_reg_value( hkey, chip_typeW, REG_BINARY, desc, size ); set_reg_value( hkey, dac_typeW, REG_BINARY, ramdacW, sizeof(ramdacW) );
+ gpu_qw_memory_size = gpu->memory_size; + + /* We failed to retrieve the gpu memory size set a default of 4Gb */ + if (!gpu_qw_memory_size) + { + gpu_qw_memory_size = 4294967296LL;
On second thought, let's use a smaller amount like 1G. If a GPU doesn't support Vulkan, it must be one of the old GPUs. Reporting a large amount might let applications think it's okay to use that much memory so smaller ones seem safer here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4466#note_53647