Re: [PATCH v12 0/3] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/combase/combase.c:
> }
>
> -static HRESULT clsid_from_string_reg(LPCOLESTR progid, CLSID *clsid)
> +static HRESULT clsid_from_string_reg(LPCOLESTR progid, CLSID *clsid, BOOL forceassign)
>  {
> -    WCHAR buf2[CHARS_IN_GUID];
> -    LONG buf2len = sizeof(buf2);
> -    HKEY xhkey;
> -    WCHAR *buf;
> +    HRESULT ret = CO_E_CLASSSTRING;
> +    HKEY xhkey = NULL;
> +    WCHAR szclsid[256] = {0};
> +    LONG cbclsid = sizeof(szclsid);
> +    CLSID origclsid = *clsid;
> +    static LPCOLESTR visited[16];
> +    static int visitedcount = 0;
> Why is this static and why are you using specifically 16 elements?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_116877