Re: [PATCH v2 0/9] MR538: mshtml: Implement more methods for Elements.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/htmlelem.c:
> {
>      HTMLElement *This = impl_from_IHTMLElement6(iface);
> -    FIXME("(%p)->(%s %s %p)\n", This, debugstr_variant(pvarNS), debugstr_w(strAttributeName), AttributeValue);
> -    return E_NOTIMPL;
> +    nsAString ns_str, name_str, value_str;
> +    const PRUnichar *ns;
> +    nsresult nsres;
> +    HRESULT hres;
> +
> +    TRACE("(%p)->(%s %s %p)\n", This, debugstr_variant(pvarNS), debugstr_w(strAttributeName), AttributeValue);
> +
> +    hres = variant_to_nsstr(pvarNS, FALSE, &ns_str);
> +    if(FAILED(hres))
> +        return hres;
> +    nsAString_GetData(&ns_str, &ns);
> +    if(ns && !ns[0]) {
> Why do you still need it?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/538#note_5111