Huw Davies (@huw) commented about dlls/iphlpapi/iphlpapi_main.c:
* RETURNS * Success: TRUE * Failure: FALSE - * - * FIXME - * Stub, returns FALSE. */ -BOOL WINAPI GetRTTAndHopCount(IPAddr DestIpAddress, PULONG HopCount, ULONG MaxHops, PULONG RTT) -{ - FIXME("(DestIpAddress 0x%08lx, HopCount %p, MaxHops %ld, RTT %p): stub\n", - DestIpAddress, HopCount, MaxHops, RTT); - return FALSE; +BOOL WINAPI GetRTTAndHopCount( IPAddr DestIpAddress, PULONG HopCount, ULONG MaxHops, PULONG RTT ) +{ Could we change the parameter names to be snake_case - e.g. `dest_addr`, `hop_count`? Also `PULONG` -> `ULONG *`.
There is also trailing whitespace after the opening brace. There are other instances of trailing whitespace below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4853#note_60977