9 May
2023
9 May
'23
11:42 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
* other values up one slot. Normalize to SM5.1. */ param->idx[2] = param->idx[1]; param->idx[1] = param->idx[0]; + ++param->idx_count;
I don't really know what I'm talking about here, but after reading that my first though is: "Shouldn't we check that `idx_count` is not already three? And shouldn't we zero `idx[0]`?". -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198#note_32272