Re: [PATCH 0/1] MR5040: dmband: Implement getting/setting GUID_BandParam on band tracks.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/dmband/bandtrack.c:
> return DMUS_E_TYPE_UNSUPPORTED;
>
> if (IsEqualGUID(type, &GUID_BandParam))
> -        FIXME("GUID_BandParam not handled yet\n");
> +    {
> +        struct band_entry *entry = calloc(1, sizeof(*entry));
> +        DMUS_BAND_PARAM *band_param = param;
> +        if (!band_param || !band_param->pBand)
> +            return E_POINTER;
> +        if (!entry)
> +            return E_OUTOFMEMORY;
> +        entry->band = band_param->pBand;

```suggestion:-6+0
        struct band_entry *entry;
        DMUS_BAND_PARAM *band_param = param;
        if (!band_param || !band_param->pBand)
            return E_POINTER;
        if (!(entry = calloc(1, sizeof(*entry))))
            return E_OUTOFMEMORY;
        entry->band = band_param->pBand;
```

To avoid a potential leak on error.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5040#note_60316