21 Aug
2023
21 Aug
'23
7:57 p.m.
On Mon Aug 21 18:54:47 2023 +0000, Bartosz Kosiorek wrote:
Generally, we should checkout the return value of `GetDIBits`, like: ```suggestion:-0+0 if (GetDIBits(screendc, iinfo.hbmColor, 0, height, lockeddata.Scan0, (BITMAPINFO*)&bih, DIB_RGB_COLORS)) { ``` and exit properly if it is fails (`DeleteDC`). It does seem like a good idea to check the return value and respond appropriately. I think I can add such a check in a cleaner way in part 2, than in part 1.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3621#note_42898