R��mi Bernon (@rbernon) commented about dlls/dinput/tests/joystick8.c:
check_object_inst( objinst, expect_objects[8] ); check_member( objinst, expect_objects[8], "%#lx", dwFlags );
+ /* c_dfDIJoystick2 is broken when it comes to more than two sliders */ + hr = IDirectInputDevice8_GetObjectInfo( device, &objinst, offsetof(DIJOYSTATE2, rglVSlider[0]), DIPH_BYOFFSET ); + ok( hr == DIERR_NOTFOUND, "GetObjectInfo returned: %#lx\n", hr );
This should be broken with the backward lookup and fixed by going forward, right? Is there a way we can have the tests first, then the fixes to make it clear? I understand the GUID change also plays a part here, so don't bother too much if it gets complicated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/507#note_4843