Re: [PATCH 0/5] MR3528: winegstreamer: Implement windows api frontend for file media sink.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/media_sink.c:
> #include "mferror.h"
> +#include "mfapi.h"
>
> #include "wine/debug.h"
>
> WINE_DEFAULT_DEBUG_CHANNEL(mfplat);
>
> +struct stream_sink
> +{
> +    IMFStreamSink IMFStreamSink_iface;
> +    LONG refcount;
> +    DWORD id;
> +
> +    IMFMediaType *type;
> +    IMFMediaEventQueue *event_queue;
> +    struct media_sink *media_sink;
> Imho it's better to use the interface pointer when you are keeping a reference to it. And using the internal struct only when you are holding no reference or a private reference to it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3528#note_41598