Re: [PATCH v2 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)

[Erich Hoover (＠ehoover)]

On Thu Sep 29 21:54:26 2022 +0000, Joel Holdsworth wrote:
> Here is a new version of the patch-set with the following changes:
> * Limited flag storage to `FILE_ATTRIBUTE_HIDDEN` and `FILE_ATTRIBUTE_SYSTEM`
> * `WARN` if we get something other than ENODATA or ENOTSUP
> * Handle Samba v4 metadata gracefully and print a one-time warning.
> @jhol I may be misinterpreting AJ's comment, but I believe that he would like it to not store the xattr (rather than masking the stored value) when the flags are not in the mask list.  So, something more like:
static int fd_set_dos_attrib( int fd, ULONG attr )
{
    /* we only store the HIDDEN and SYSTEM attributes */
    if ((attr & XATTR_ATTRIBS_MASK) == 0)
        return 0;
...

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/951#note_9801