19 Jul
2023
19 Jul
'23
2:02 a.m.
On Wed Jul 19 02:02:04 2023 +0000, Henri Verbeet wrote:
```diff - d3d12_desc_copy(&dst[dst_idx], &src[src_idx], device); + d3d12_desc_copy(&dst[dst_idx], &src[src_idx], dst_heap, device); ```
Do we really need to pass "device" around if we're already passing "dst_heap"? As you mention in the commit message, we don't end up accessing "device" in a lot of places any more, and it seems like we could use "dst_heap->device" when we do. This function is the main reason for much lower performance vs Windows in HZD at least. Not loading device from dst_heap when we can have it in a register is an advantage. I've added a comment to clarify.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/272#note_39365