29 Apr
2025
29 Apr
'25
10:32 p.m.
On Tue Apr 29 08:20:44 2025 +0000, Dmitry Timoshkov wrote:
Aren't missing failures indicate that the propsed changes are correct? Otherwise what kind of test failres did you expect to see? I'm a little bit lost... Missing failures could also mean that the tests are not correctly checking the relevant functionality. Adding the test with `todo_wine` first and then removing the `todo_wine` in the following commits would clearly show that there is an issue and that it's fixed by the proposed changes.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5068#note_102201