17 Jan
2024
17 Jan
'24
8:16 a.m.
Rémi Bernon (@rbernon) commented about dlls/dmime/audiopath.c:
+ break; + default: + WARN("Unknown %s\n", debugstr_chunk(&chunk)); + break; + } + } +done: + if (FAILED(hr)) { + if (pchannel_to_buffer) + { + free(pchannel_to_buffer->guids); + free(pchannel_to_buffer); + } + return hr; + } + return S_OK; You can combine the ifs with && and return hr. Also with a single alloc you could even get rid of the `if (pchannel_to_buffer)`.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4852#note_57671